Kevin Kubasik’s Personal Blog
RSS icon Email icon Home icon
  • Code Review in Rietveld with bzr/Bazaar

    Posted on February 9th, 2009 Kevin Kubasik 3 comments

    I like bzr. Those of us that do (like bzr) aren’t quite as popular as the git lovers and as a result, we don’t see tools as fantastic as Rietveld, Github and Git-CL being spread around on domains outside of launchpad.net. While this isn’t the end of the world, it certainly represented a hurdle when I decided that I was going to formalize my code review process for internal projects. 

    While most applications have some form of bzr support, its generally pretty broken or outdated. Given that I was going to have to write code no matter what application I chose, I figured I would use my favorite: Rietveld. Rietveld already had a tool supporting Git and Hg, so expanding it to support bzr was a straightforward task. The initial patch is awaiting review at http://codereview.appspot.com/14053  so please share your thoughts/opinions. If there are others who start to use this, then I might consider packaging this functionality into a bzr plugin! 

    If you just want to take advantage of bzr support, then download the file here: Upload.py

     

    3 responses to “Code Review in Rietveld with bzr/Bazaar”

    1. Very cool! Glad to see the Bazaar toolchain expanding it’s nebulous tendrils :)

      That said, as a Launchpad developer I have to ask: what don’t you like about our code review system? what can we do better?

    2. Hey, neat patch. I wonder if you would be a happier camper using bzrlib instead of running it in a separate shell; you depend on bzr anyway, so it’s there. I wrote a little branch analyzer using bzrlib and was just shocked at how easy it was.

    3. Thanks a lot for this! We’re going to demo using Rietveld for code reviews in Mixxx (http://mixxx.org) and this looks like just the tool we need to get it integrated into our workflow.

    Leave a reply